Skip to content

Conversation

@nayonsoso
Copy link
Collaborator

No description provided.

wibaek and others added 10 commits February 22, 2025 17:40
* feat: 지원서 제출 시 응답에 지원 횟수 추가

* fix: 지원서 제출 최대 횟수 3번으로 수정

* refactor: 불필요한 조건문 제거

* fix: V8 -> V10으로 변경

* style: 개행 추가
* refactor: SiteUser에서 MyPage로 서비스명 변경하여 역할 명확화

* feat: 닉네임 중복 검증 api 추가

* style: 컨트롤러 메서드 인자 개행 컨벤션 적용

* refactor: checkNicknameExists로 함수명 개선
* refactor: GPA 대신 GpaResponse DTO로 응답 구조 개선

* refactor: LanguageTest 대신 LanguageTestResponse DTO로 응답 구조 개선
* chore: ci 스크립트 작성

* chore: 테스트용 application.yml 분리

* test: test profile 제거

* refactor: 애플 시크릿키를 yml로 이동

* refactor: 함수 이름 변경

* refactor: 오타 수정

* refactor: redis testcontainers 설정 수정

* refactor: ddl-auto 옵션 변경

- create-drop을 create로 변경
- 테스트 컨테이너를 실행해서 테스트하기 때문에, 테스트가 종료되면 당연히 테이블이 삭제된다. 따라서 create-drop을 하는것과 create를 하는 것이 동일하게 동작한다. 굳이 create로 바꾼 것은 삭제 시 FK 위반으로 WARN 로그가 불필요하게 백몇줄이 찍히는걸 막기 위해서.

* test: e2e 테스트 수정

- 깨지는 테스트 수정
- 비지니스 로직 변경으로 더 이상 해당되지 않는 테스트 삭제

* chore: createAt과 updateAt의 나노초 길이 고정

* style: 주석 추가

* refactor: MySQL 테스트 컨테이너 설정 변경

- redis 테스트 컨테이너와 동일하게 설정하여 불필요한 인지 부하를 줄인다.
@nayonsoso nayonsoso added the 릴리즈 Marks pull request for release label Apr 5, 2025
@nayonsoso nayonsoso requested review from Gyuhyeok99 and wibaek April 5, 2025 18:50
@coderabbitai
Copy link

coderabbitai bot commented Apr 5, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@nayonsoso nayonsoso closed this Apr 8, 2025
@nayonsoso nayonsoso deleted the release branch April 8, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

릴리즈 Marks pull request for release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants