Skip to content

Conversation

@wibaek
Copy link
Member

@wibaek wibaek commented Apr 13, 2025

기능 추가/변경 사항

  • 유저 생일과 성별 정보 삭제

리팩토링 사항

  • @PageableDefault 및 페이지 검증 로직을 ArgumentResolver로 개선
  • e2e 테스트 제거
  • gradle 의존성 정리

외 변경사항

  • DB 변경

Gyuhyeok99 and others added 7 commits April 8, 2025 21:23
* refactor: 커스텀 PageRequest 및 ArgumentResolver 추가

* refactor: 커스텀 PageRequest 및 ArgumentResolver 등록 및 적용

* refactor: 매직 넘버 상수로 교체

* feat: 커스텀 페이지 요청 argument resolver 추가

* feat: 커스텀 페이지 요청 argument resolver 적용

* refactor: 모든 유효하지 않는 값에 대해서 기본값으로 대체

* refactor: 최대 사이즈 초과 시 최대 사이즈 반환하도록 수정

* refactor: DEFAULT_PAGE 0으로 변경

* refactor: ParameterizedTest를 활용하여 중복 테스트 코드 제거

* refactor: 불필요한 override 제거

* refactor: 페이징 처리 테스트코드 분리 및 가독성 개선
* feat: 가입시 생년월일과 성별을 선택하지 않게 변경

* remove: SIteUser에서 birth, gender 제거, 사용처들에서 삭제

* feat: Flyway site_user 테이블에서 gender, birth 삭제

* feat: 내 정보 API에서 생일 데이터 삭제

* remove: Gender enum 삭제
* refactor: e2e 관련 테스트 코드 삭제

* chore: todo 주석 추가

* chore: rest assured 의존성 제거
* chore: gradle 의존성 정리

* refactor: 소스 코드에서 QClass 제거

- QClass는 '수정할 수 있는 소스코드'가 아니므로, 소스코드에서 지웁니다.
- 빌드될 때 기본 위치(/build/generated/sources/annotationProcessor/java/main)에 자동으로 생성되게 합니다.
- 누락된 언더바를 추가합니다.
@wibaek wibaek added the 릴리즈 Marks pull request for release label Apr 13, 2025
@coderabbitai
Copy link

coderabbitai bot commented Apr 13, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@wibaek
Copy link
Member Author

wibaek commented Apr 15, 2025

db변경이 급해서 바로 배포하겠습니다!

@wibaek wibaek merged commit 9781c5b into master Apr 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

릴리즈 Marks pull request for release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants