-
Notifications
You must be signed in to change notification settings - Fork 8
chore: Alloy를 이용한 로깅 추가 #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Walkthrough
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Gyuhyeok99
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alloy로 변경하셨군요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alloy가 비교적 최신 기술이라 자칫 이해하기 힘들수도 있는데,
달아주신 주석 덕분에 이해가 수월했습니다 ㅎㅎ
💁🏻♀️💁🏻♀️ 그리고 위백님이 블로그에 정리하신 내용을 위키에도 적으면 좋을 것 같은데 어떤가요?
| loki.process "spring_labels" { | ||
| forward_to = [loki.write.grafana_loki.receiver] // 처리된 로그를 Loki로 전송 | ||
|
|
||
| stage.static_labels { | ||
| values = { | ||
| "job" = "spring", | ||
| "service" = "backend", | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
제가 알기로, (그리고 혹시 몰라 지피티한테도 물어보기도 했는데요)
로키는 로그를 "라벨의 조합"으로만 구분해서,
이렇게 할 경우 stage의 로그와 production의 로그가 한 곳에 섞일수도 있을 것 같습니다..!
혹시 모르니 이렇게 설정하신 후, 🔥실제 그라파나에서 어떻게 동작하는지 확인해보시는게 필요할 것 같습니다.🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그렇네요! 이전 Promtail 로그와 섞여서 문제가 있는걸 발견하지 못했네요. 확인해주셔서 감사합니다!
로키 로그도 비우고 환경내용도 로그에 포함시키도록 하겠습니다!
docs/config.alloy
Outdated
| batch_wait = "1s" // 로그 배치 전송 대기 시간 | ||
| batch_size = "1MB" // 로그 배치 크기 | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EOF 개행해주세요😊
네! 블로그 내용 좀더 보강하고 위키에도 적어두도록 하겠습니다! |
관련 이슈
작업 내용
로컬에서 테스트해서 작동되는지 확인했습니다!
특이 사항
리뷰 요구사항 (선택)