-
Notifications
You must be signed in to change notification settings - Fork 8
refactor: 회원 탈퇴 API HTTP Method를 PATCH에서 DELETE로 변경 #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: 회원 탈퇴 API HTTP Method를 PATCH에서 DELETE로 변경 #311
Conversation
Walkthrough
Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/main/java/com/example/solidconnection/auth/controller/AuthController.java (1)
29-29: REST API 설계 원칙에 맞게 변경되었습니다! 👍
HTTP 메서드의 의미론적 사용 개선
- 회원 탈퇴 API에
@PatchMapping보다@DeleteMapping이 더 적합합니다- PATCH는 리소스를 부분적으로 업데이트할 때 사용하는 반면, DELETE는 리소스를 제거할 때 사용하는 메서드입니다
- 회원 탈퇴는 본질적으로 사용자 리소스를 제거하는 작업이므로 DELETE 메서드가 REST 원칙에 더 부합합니다
작은 개선 제안
- 30번 라인의
import org.springframework.web.bind.annotation.PatchMapping이 더 이상 사용되지 않는 것 같습니다- 클래스에서 다른 메서드에서
@PatchMapping을 사용하지 않는다면 이 import문을 제거해도 좋을 것 같습니다Also applies to: 106-106
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/main/java/com/example/solidconnection/auth/controller/AuthController.java(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build
nayonsoso
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
빠른 반영 좋습니다~ 😊👍
관련 이슈
작업 내용
위 내용을 적용한 아주 간단한 pr입니다 ㅎㅎ