Issue 167 #184
Closed
Issue 167 #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurii-prykhodko-solid
requested changes
Dec 4, 2024
| return AvoidReturningWidgetsParameters( | ||
| exclude: exclude, | ||
| exclude: ExcludeParameters.fromJson( | ||
| excludeList: json['exclude'] as Iterable, |
Collaborator
There was a problem hiding this comment.
I think we can make this key reusable, so that all other rules use it consistently.
Comment on lines
+75
to
+80
|
|
||
| bool _hasThrowExpression(Statement node) { | ||
| final visitor = ThrowExpressionVisitor(); | ||
| node.accept(visitor); | ||
| return visitor.nodes.isNotEmpty; | ||
| } |
Collaborator
There was a problem hiding this comment.
Please sync with master -- these changes have already been applied there.
| class AvoidReturningWidgetsExclude { | ||
|
|
||
| /// Model class for ExcludeRule parameters | ||
| class ExcludeRule { |
Collaborator
There was a problem hiding this comment.
Let's think about better naming here, this isn't a rule.
ExcludedIdentifiersParameter maybe?
Suggested change
| class ExcludeRule { | |
| class ExcludeRule { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.