issue-93. added new consider_making_a_member_privat rule #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurii-prykhodko-solid
requested changes
Dec 5, 2024
Comment on lines
5
to
19
| class X { | ||
| // expect_lint:consider_making_a_member_private | ||
| void unusedX() {} | ||
|
|
||
| // no lint | ||
| void usedX() {} | ||
| } | ||
|
|
||
| class Y { | ||
| // no lint | ||
| void _y() { | ||
| final x = X(); | ||
| x.usedX(); | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Add more tests for:
- fields (static, final, mutable)
- getters, setters
- methods (static/instance)
- constructors, factories
We should also consider this for non-class declarations (global functions, variables, constants) and class declarations as a whole.
Comment on lines
56
to
65
| class Y { | ||
| // no lint | ||
| void _y() { | ||
| final x = X(); | ||
| X.usedFactory(); | ||
| x.usedMethodX(); | ||
| usedGLobalFunction(); | ||
| usedGlobalVariables; | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
This is not quite what the lint is supposed to do.
With the structure of the test, all these methods and functions could just as well be private too.
We should lint if the class/method/functions are not used outside the file where they are declared.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.