feat: add named_parameters_ordering #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solid-vovabeloded
requested changes
Apr 24, 2025
Collaborator
solid-vovabeloded
left a comment
solid-vovabeloded
left a comment
There was a problem hiding this comment.
Great job so far, @Andrew-Bekhiet! I've added a couple of suggestions here - please, take a look.
lib/src/lints/named_parameters_ordering/models/parameter_type.dart
Outdated
Show resolved
Hide resolved
lib/src/lints/named_parameters_ordering/named_parameters_ordering_rule.dart
Outdated
Show resolved
Hide resolved
lib/src/lints/named_parameters_ordering/named_parameters_ordering_rule.dart
Outdated
Show resolved
Hide resolved
lib/src/lints/named_parameters_ordering/named_parameters_ordering_rule.dart
Outdated
Show resolved
Hide resolved
lib/src/lints/named_parameters_ordering/named_parameters_ordering_rule.dart
Outdated
Show resolved
Hide resolved
lib/src/lints/named_parameters_ordering/visitors/named_parameters_ordering_visitor.dart
Outdated
Show resolved
Hide resolved
solid-vovabeloded
approved these changes
Apr 24, 2025
Collaborator
solid-vovabeloded
left a comment
solid-vovabeloded
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Contributor
Author
|
I actually forgot to add the changes to CHANGELOG.md, I'll add them and let me know if I can merge it or if you're going to it instead |
extract models from visitor into their separate files rename some ParameterType enums to avoid using dart keywords add ParameterType.fromType remove unnecessary base class from documentation text perf(rule): make visitor a class member to avoid recreating new instance update test with new default ordering
solid-vovabeloded
force-pushed
the
feat-named-parameters-order
branch
from
a72cf5e to
419499e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #181
renamed super_required to required_super
Feel free to request changing the default parameters ordering