generate: skip unnecessary unmask steps and warn user about it#2
Merged
someonenameguy merged 1 commit intosomeonenameguy:mainfrom Jan 27, 2026
Merged
generate: skip unnecessary unmask steps and warn user about it#2someonenameguy merged 1 commit intosomeonenameguy:mainfrom
someonenameguy merged 1 commit intosomeonenameguy:mainfrom
Conversation
Running the model against inputs without any `[mask]` token is absurd and useless, try to intercept this situation and skip the model when sampling.
Owner
Author
|
Did not realize links would ping the original PR. SORRY |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running the model against inputs without any
[mask]token is absurd and useless, try to intercept this situation and skip the model when sampling.[Link Removed]