fix: resolve lint and signing issues by WRRicht3r · Pull Request #1247 · soramitsu/fearless-Android

WRRicht3r · 2026-02-18T13:10:04Z

Summary

Build tooling: Forced Gradle to pick the published com.android.tools:r8:8.8.34 instead of the missing 8.8.24 artifact (gradle/libs.versions.toml:72, build.gradle:25-36) to keep Kotlin 2.1 metadata compatible. Release notes were expanded with explicit validation and rollout steps so 4.2.0 packaging expectations stay in sync (docs/ releases/4.2.0.md:1-80).
Lint/perf fixes: Suppressed the safe vibrator call and removed the incompatible setHasFixedSize usage so lint stops blocking (common/src/main/java/jp/co/soramitsu/common/vibration/DeviceVibrator.kt:1-17, common/src/main/java/jp/co/soramitsu/common/view/bottomSheet/list/dynamic/DynamicListBottomSheet.kt:45-48). Escaped the literal percent signs for APY across the base strings and all translated locales to satisfy StringFormatInvalid (common/src/main/res/values/strings.xml:918-919, along with the corresponding values-pt, values-ru, values-tr, values-vi, values- zh, values-ja, values-in files at their staking string entries).
Runtime tests: Updated the ChainAssetRemote fixture to pass coinbaseUrl = null and made the Mockito eq(emptyList()) calls type-safe so Kotlin 2.1 unit tests compile again (runtime/src/test/java/jp/co/soramitsu/runtime/multiNetwork/chain/ChainSyncServiceTest.kt:40-154).
Signing workflow: Added keystore resolution helpers that read the release keystore path/password/alias from environment variables or local.properties, then fall back to the repo-local fearless-upload.jks (app/build.gradle:1- 59). Added the new keystore file to .gitignore so it remains untracked (.gitignore:18-20).

Related Issue

Closes # (or) Relates to #

Type of Change

Screenshots / Videos

If UI changes, include before/after.

Test Plan

Commands run locally:

./gradlew detektAll
./gradlew runTest
./gradlew :app:lint

Additional checks and scenarios covered:

Risks & Rollout

Potential impact, migrations, or config/secrets required.

Checklist

Linked an issue and added a clear description
Added/updated tests for changed code (where applicable)
Updated docs (README/AGENTS) when behavior or commands changed
Ran detektAll, runTest, and :app:lint locally (or via CI)
No secrets or local.properties committed

takemiyamakoto · 2026-02-18T13:20:44Z

@codex klanker bro, what do you say?

chatgpt-codex-connector · 2026-02-18T13:20:55Z

To use Codex here, create an environment for this repo.

takemiyamakoto · 2026-02-18T13:22:10Z

@codex review deez

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6c7935ad2b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

common/src/main/res/values/strings.xml

app/build.gradle

takemiyamakoto · 2026-02-19T12:19:10Z

@codex how is this?

chatgpt-codex-connector · 2026-02-19T12:31:25Z

I’d call this “close, but not ready to merge yet”.

Quick verdict

The two P2 comments look valid to me, and both can cause real regressions:

APY label regression (%% shown to users).
The base string currently contains Estimated rewards (%% APY), which will render literally if read as plain text (not String.format-expanded). That means users may indeed see %%. common/src/main/res/values/strings.xmlL918
The same double-percent pattern appears across localized string files too, so this is not isolated to English. common/src/main/res/values-pt/strings.xmlL796 common/src/main/res/values-ru/strings.xmlL891 common/src/main/res/values-tr/strings.xmlL873 common/src/main/res/values-vi/strings.xmlL903 common/src/main/res/values-zh/strings.xmlL868 common/src/main/res/values-ja/strings.xmlL868 common/src/main/res/values-in/strings.xmlL816
CI signing fallback regression risk.
ci signing now resolves/falls back to fearless-upload.jks in the repo root, but that file is ignored by git, so fresh clones/partially configured CI can fail to sign release builds if env/local props are missing. app/build.gradleL41-L48 .gitignoreL18-L20

Recommendation

Address both P2s before merge.
- APY strings: switch to single % with formatted="false" (or equivalent safe approach) for plain-text labels.
- Signing fallback: restore a tracked fallback keystore path (or fail fast with explicit validation) to avoid silent CI breakage.

Commands I used to verify

rg --files -g 'AGENTS.md'
cat AGENTS.md
cat app/AGENTS.md
cat common/AGENTS.md
nl -ba common/src/main/res/values/strings.xml | sed -n '900,930p'
nl -ba app/build.gradle | sed -n '1,90p'
nl -ba .gitignore | sed -n '1,40p'
rg -n "%% APY|%% TAE|%%" common/src/main/res/values*/*.xml | head -n 40
git status --short

View task →

R8 and stabilize runtime tests

takemiyamakoto · 2026-02-22T14:43:41Z

@codex how is this?

chatgpt-codex-connector · 2026-02-22T14:58:41Z

Summary

I addressed the two P2 review concerns and prepared a follow-up commit/PR:
- APY label regression fixed by switching staking APY strings from %% APY to % APY and adding formatted="false" for the two affected keys in base and localized resources, so plain-text usage won’t render %%. common/src/main/res/values/strings.xmlL918-L919 common/src/main/res/values/strings.xmlL1090-L1091 common/src/main/res/values-pt/strings.xmlL796-L797 common/src/main/res/values-pt/strings.xmlL968-L969 common/src/main/res/values-ru/strings.xmlL891-L892 common/src/main/res/values-ru/strings.xmlL1065-L1066 common/src/main/res/values-tr/strings.xmlL873-L874 common/src/main/res/values-tr/strings.xmlL1045-L1046 common/src/main/res/values-vi/strings.xmlL903-L904 common/src/main/res/values-vi/strings.xmlL1075-L1076 common/src/main/res/values-zh/strings.xmlL868-L869 common/src/main/res/values-zh/strings.xmlL1039-L1040 common/src/main/res/values-ja/strings.xmlL868-L869 common/src/main/res/values-ja/strings.xmlL1039-L1040 common/src/main/res/values-in/strings.xmlL816-L817 common/src/main/res/values-in/strings.xmlL988-L989
- CI signing fallback restored to tracked debug-keystore.jks for the ci signing config fallback path, avoiding failures when release keystore env/local properties are absent. app/build.gradleL41-L48
- Removed the newly added ignore entry for fearless-upload.jks from .gitignore to align with the fallback reversion. .gitignoreL15-L19
- Updated docs per repo policy (docs/status.md, docs/roadmap.md). docs/status.mdL1-L10 docs/roadmap.mdL5-L8
Commit created on current branch:
- 86e587192 — fix: address PR feedback for APY labels and CI signing fallback
I also created the requested follow-up PR via make_pr with title:
- fix: follow-up for lint/signing PR feedback (APY labels + keystore fallback)

Testing

✅ rg -n "staking_custom_validators_settings_sort_apy|staking_validator_apy_percent" common/src/main/res/values*/strings.xml
✅ rg -n "staking_custom_validators_settings_sort_apy|staking_validator_apy_percent" common/src/main/res/values*/strings.xml | rg "%%" || true
⚠️ ./gradlew :app:processDebugResources (failed due to environment missing Android SDK path / sdk.dir/ANDROID_HOME, not due to code logic)

View task →

takemiyamakoto · 2026-03-04T12:37:59Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0a8fb3cd29

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

app/build.gradle

common/src/main/res/values/strings.xml

takemiyamakoto · 2026-03-04T13:48:39Z

@codex review again

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: def8423a21

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

common/src/main/res/values/strings.xml

takemiyamakoto · 2026-03-04T14:50:29Z

@codex what do you think?

chatgpt-codex-connector · 2026-03-04T14:55:07Z

Summary

I agree with the reviewer: this was not ready as-is, and I applied a follow-up fix so APY labels now render correctly with a single % in plain getString(...) paths by using formatted="false" on both staking APY keys in base strings. common/src/main/res/values/strings.xmlL918-L919 common/src/main/res/values/strings.xmlL1090-L1091
I applied the same APY fix across all affected localized resources to keep behavior consistent by locale (pt/ru/tr/vi/zh/ja/in). common/src/main/res/values-pt/strings.xmlL796-L797 common/src/main/res/values-pt/strings.xmlL968-L969 common/src/main/res/values-ru/strings.xmlL891-L892 common/src/main/res/values-ru/strings.xmlL1065-L1066 common/src/main/res/values-tr/strings.xmlL873-L874 common/src/main/res/values-tr/strings.xmlL1045-L1046 common/src/main/res/values-vi/strings.xmlL903-L904 common/src/main/res/values-vi/strings.xmlL1075-L1076 common/src/main/res/values-zh/strings.xmlL868-L869 common/src/main/res/values-zh/strings.xmlL1039-L1040 common/src/main/res/values-ja/strings.xmlL868-L869 common/src/main/res/values-ja/strings.xmlL1039-L1040 common/src/main/res/values-in/strings.xmlL816-L817 common/src/main/res/values-in/strings.xmlL988-L989
Per repo policy, I updated status/roadmap docs in the same change set. docs/status.mdL3-L10 docs/roadmap.mdL5-L8
Committed on current branch: 6c38ebba4 (fix: resolve APY string formatting regression).
I also created the follow-up PR via make_pr with title: fix: follow-up review on APY labels and string formatting.

Testing

✅ curl -L -s https://developer.android.com/guide/topics/resources/string-resource | rg -n "formatted=|If you need to use a literal percent|String.format" | head -n 10
✅ rg -n "staking_custom_validators_settings_sort_apy|staking_validator_apy_percent" common/src/main/res/values*/strings.xml
✅ rg -n "%% APY" common/src/main/res/values*/strings.xml || true
⚠️ ./gradlew :common:processDebugResources (fails in this environment due missing Android SDK config: ANDROID_HOME / sdk.dir)

View task →

takemiyamakoto · 2026-03-05T12:29:45Z

@codex are you fearless ser?

chatgpt-codex-connector · 2026-03-05T12:41:26Z

Always 😎 — fearless, but still cautious with regressions.

If you want, I can do a focused re-review pass right now on the latest head commit and call out only merge-blocking issues.

View task →

takemiyamakoto · 2026-03-06T08:25:13Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 33f66996ff

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

feature-account-impl/src/main/java/jp/co/soramitsu/account/impl/domain/AccountInteractorImpl.kt

...wallet-impl/src/main/java/jp/co/soramitsu/wallet/impl/data/historySource/TonHistorySource.kt

takemiyamakoto · 2026-03-06T11:39:26Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 926c0bb689

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

...-tonconnect-api/src/main/java/jp/co/soramitsu/tonconnect/api/model/TonConnectUrlValidator.kt

runtime/src/main/java/jp/co/soramitsu/runtime/multiNetwork/chain/remote/TonRemoteSource.kt

takemiyamakoto · 2026-03-06T15:21:24Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e1ccd003f3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

...-tonconnect-api/src/main/java/jp/co/soramitsu/tonconnect/api/model/TonConnectUrlValidator.kt

takemiyamakoto · 2026-03-07T15:14:18Z

@codex any other issues?

chatgpt-codex-connector · 2026-03-07T15:27:41Z

Yep — I still see one real issue remaining.

Remaining issue (still open)

The staking APY labels are still stored as %% APY in base and localized resources, which will render literally as %% in UI paths that call resourceManager.getString(title) with no format args. The validator sorting UI uses that plain getString(...) path, so this is still a user-facing text regression. Use single % with formatted="false" for those keys. common/src/main/res/values/strings.xmlL918-L919 common/src/main/res/values/strings.xmlL1090-L1091 feature-staking-impl/src/main/java/jp/co/soramitsu/staking/impl/presentation/common/filters/ValidatorsSettingsViewModel.ktL42-L43

What looks good from a quick re-check

TonConnect URL normalization currently preserves query params, re-brackets IPv6 origins, and blocks IPv6 ULA/private ranges — those earlier review concerns appear addressed in code now. feature-tonconnect-api/src/main/java/jp/co/soramitsu/tonconnect/api/model/TonConnectUrlValidator.ktL29-L35 feature-tonconnect-api/src/main/java/jp/co/soramitsu/tonconnect/api/model/TonConnectUrlValidator.ktL90-L96 feature-tonconnect-api/src/main/java/jp/co/soramitsu/tonconnect/api/model/TonConnectUrlValidator.ktL128-L135
TON history cursor/hash and fee mapping logic also appears fixed in current head (hash-part checks + fee propagation into extra). feature-wallet-impl/src/main/java/jp/co/soramitsu/wallet/impl/data/historySource/TonHistorySource.ktL57-L66 runtime/src/main/java/jp/co/soramitsu/runtime/multiNetwork/chain/remote/TonRemoteSource.ktL524-L548

Checks I ran

✅ rg --files -g 'AGENTS.md'
✅ nl -ba feature-tonconnect-api/src/main/java/jp/co/soramitsu/tonconnect/api/model/TonConnectUrlValidator.kt | sed -n '1,240p'
✅ nl -ba feature-wallet-impl/src/main/java/jp/co/soramitsu/wallet/impl/data/historySource/TonHistorySource.kt | sed -n '1,260p'
✅ nl -ba runtime/src/main/java/jp/co/soramitsu/runtime/multiNetwork/chain/remote/TonRemoteSource.kt | sed -n '480,580p'
✅ rg -n "%% APY|staking_custom_validators_settings_sort_apy|staking_validator_apy_percent" common/src/main/res/values*/strings.xml
✅ nl -ba feature-staking-impl/src/main/java/jp/co/soramitsu/staking/impl/presentation/common/filters/ValidatorsSettingsViewModel.kt | sed -n '1,90p'

If you want, I can apply the APY string fix across all affected locales now in a follow-up commit.

View task →

fix: resolve lint and signing issues

6c7935a

chatgpt-codex-connector bot reviewed Feb 18, 2026

View reviewed changes

common/src/main/res/values/strings.xml Show resolved Hide resolved

app/build.gradle Outdated Show resolved Hide resolved

fix: stabilize runtime tests

c2eebf4

WRRicht3r added 3 commits February 19, 2026 13:58

fix: update R8/AGP and stabilize runtime tests

3a244f9

fix: align AGP/

06ee301

R8 and stabilize runtime tests

fix: align AGP/R8 and stabilize runtime tests

757a8a9

WRRicht3r added 2 commits March 4, 2026 10:28

fix: stabilize service fragment state

b8c7121

fix: suppress missing xml service references

0a8fb3c

chatgpt-codex-connector bot reviewed Mar 4, 2026

View reviewed changes

app/build.gradle Show resolved Hide resolved

common/src/main/res/values/strings.xml Show resolved Hide resolved

fix: fail when ci keystore missing

def8423

chatgpt-codex-connector bot reviewed Mar 4, 2026

View reviewed changes

common/src/main/res/values/strings.xml Show resolved Hide resolved

fix some bugs

33f6699

Cre-eD previously approved these changes Mar 6, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Mar 6, 2026

View reviewed changes

feature-account-impl/src/main/java/jp/co/soramitsu/account/impl/domain/AccountInteractorImpl.kt Outdated Show resolved Hide resolved

...wallet-impl/src/main/java/jp/co/soramitsu/wallet/impl/data/historySource/TonHistorySource.kt Outdated Show resolved Hide resolved

fix: tonconnect cleanup and ton pagination

926c0bb

WRRicht3r dismissed Cre-eD’s stale review via 926c0bb March 6, 2026 09:56

WRRicht3r requested a review from takemiyamakoto March 6, 2026 10:11

chatgpt-codex-connector bot reviewed Mar 6, 2026

View reviewed changes

...-tonconnect-api/src/main/java/jp/co/soramitsu/tonconnect/api/model/TonConnectUrlValidator.kt Show resolved Hide resolved

runtime/src/main/java/jp/co/soramitsu/runtime/multiNetwork/chain/remote/TonRemoteSource.kt Outdated Show resolved Hide resolved

takemiyamakoto previously approved these changes Mar 6, 2026

View reviewed changes

fix: ton url validator and ton fee cursor

e1ccd00

WRRicht3r dismissed takemiyamakoto’s stale review via e1ccd00 March 6, 2026 14:15

WRRicht3r requested a review from takemiyamakoto March 6, 2026 15:03

chatgpt-codex-connector bot reviewed Mar 6, 2026

View reviewed changes

...-tonconnect-api/src/main/java/jp/co/soramitsu/tonconnect/api/model/TonConnectUrlValidator.kt Outdated Show resolved Hide resolved

...-tonconnect-api/src/main/java/jp/co/soramitsu/tonconnect/api/model/TonConnectUrlValidator.kt Outdated Show resolved Hide resolved

fix: tonconnect url normalization

c9012e6

takemiyamakoto approved these changes Mar 6, 2026

View reviewed changes

WRRicht3r merged commit 6d5a966 into develop Mar 9, 2026

WRRicht3r deleted the chore/update-r8 branch March 9, 2026 08:10

WRRicht3r restored the chore/update-r8 branch March 9, 2026 08:13

Conversation

WRRicht3r commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Related Issue

Type of Change

Screenshots / Videos

Test Plan

Additional checks and scenarios covered:

Risks & Rollout

Checklist

Uh oh!

takemiyamakoto commented Feb 18, 2026

Uh oh!

chatgpt-codex-connector bot commented Feb 18, 2026

Uh oh!

takemiyamakoto commented Feb 18, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

takemiyamakoto commented Feb 19, 2026

Uh oh!

chatgpt-codex-connector bot commented Feb 19, 2026

Quick verdict

Recommendation

Commands I used to verify

Uh oh!

takemiyamakoto commented Feb 22, 2026

Uh oh!

chatgpt-codex-connector bot commented Feb 22, 2026

Summary

Uh oh!

takemiyamakoto commented Mar 4, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

takemiyamakoto commented Mar 4, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

takemiyamakoto commented Mar 4, 2026

Uh oh!

chatgpt-codex-connector bot commented Mar 4, 2026

Summary

Uh oh!

takemiyamakoto commented Mar 5, 2026

Uh oh!

chatgpt-codex-connector bot commented Mar 5, 2026

Uh oh!

takemiyamakoto commented Mar 6, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

takemiyamakoto commented Mar 6, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

takemiyamakoto commented Mar 6, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

WRRicht3r commented Feb 18, 2026 •

edited

Loading