Skip to content

Improve: Move directory name into General tab in Directory Builder #2709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RabbiIslamRony wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Improve: Move directory name into General tab in Directory Builder #2709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 9 additions & 74 deletions assets/src/js/admin/vue/apps/cpt-manager/CPT_Manager.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,33 +23,10 @@
</svg>
Back
</a>
<!-- atbdp-cptm-header -->
<div
class="directorist-row-tooltip"
data-tooltip="Click here to rename the directory."
data-flow="bottom"
>
<div
class="directorist-type-name-editable"
v-if="isEditableName || !options.name.value"
@click="ensureEditableMode"
>
<component
v-if="options.name && options.name.type"
:is="options.name.type + '-field'"
v-bind="options.name"
@update="updateOptionsField({ field: 'name', value: $event })"
ref="editableNameField"
/>
</div>
<span
class="directorist-type-name"
v-if="!isEditableName && options.name.value"
>
{{ options.name.value }}
<span class="la la-pen" @click.stop="openEditableMode"></span>
</span>
</div>
<!-- Read-only directory name display -->
<span class="directorist-type-name" v-if="options.name.value">
{{ options.name.value }}
</span>
</div>
<div class="directorist-directory-type-top-right">
<button
Expand Down Expand Up @@ -148,11 +125,6 @@ export default {
directorist_admin.enabled_multi_directory === "1";
},

beforeDestroy() {
// Clean up click outside listener when component is destroyed
document.removeEventListener("click", this.handleClickOutside);
},

data() {
return {
listing_type_id: null,
Expand All @@ -166,54 +138,12 @@ export default {
},
},
enabled_multi_directory: null,
isEditableName: false,
};
},

methods: {
...mapGetters(["getFieldsValue"]),

ensureEditableMode() {
// Only set up the listener if not already in editable mode
if (!this.isEditableName) {
this.isEditableName = true;
// Add click outside listener after a small delay to avoid immediate trigger
setTimeout(() => {
document.addEventListener("click", this.handleClickOutside);
}, 100);
}
},

openEditableMode() {
this.isEditableName = true;
// Add click outside listener after a small delay to avoid immediate trigger
setTimeout(() => {
document.addEventListener("click", this.handleClickOutside);
}, 100);
},

closeEditableMode() {
this.isEditableName = false;
// Remove click outside listener
document.removeEventListener("click", this.handleClickOutside);
},

handleClickOutside(event) {
// Check if the editable field exists
if (!this.$refs.editableNameField) {
return;
}

// Get the DOM element (component.$el for Vue components)
const editableElement =
this.$refs.editableNameField.$el || this.$refs.editableNameField;

// Check if click is outside the editable field
if (editableElement && !editableElement.contains(event.target)) {
this.closeEditableMode();
}
},

setupSaveOnKeyboardInput() {
addEventListener("keydown", (event) => {
if ((event.metaKey || event.ctrlKey) && "s" === event.key) {
Expand Down Expand Up @@ -346,6 +276,11 @@ export default {
// Get Form Fields Data
let field_list = [];
for (let field in fields) {
// Skip directory_name — it is saved via options.name, not as term meta.
if (field === "directory_name") {
continue;
}

let value = this.maybeJSON([fields[field].value]);

form_data.append(field, value);
Expand Down
6 changes: 6 additions & 0 deletions assets/src/js/admin/vue/store/CPT_Manager_Store.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,12 @@ export default new Vuex.Store({

updateFieldValue: (state, payload) => {
Vue.set(state.fields[payload.field_key], 'value', payload.value);

// Keep options.name in sync when the directory_name field changes,
// so the header label and save payload stay up-to-date.
if (payload.field_key === 'directory_name' && state.options.name) {
state.options.name.value = payload.value;
}
},

updateFieldData: (state, payload) => {
Expand Down
2 changes: 2 additions & 0 deletions assets/src/scss/layout/admin/builder/_builder_style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,8 @@ $light-gray: #f4f5f7;
font-weight: 600;
color: #141921;
line-height: 16px;
pointer-events: none;
user-select: none;
span {
font-size: 20px;
color: #747c89;
Expand Down
15 changes: 15 additions & 0 deletions includes/modules/multi-directory-setup/class-builder-data.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2040,6 +2040,15 @@ protected static function prepare_data() {

self::$fields = apply_filters(
'atbdp_listing_type_settings_field_list', [
'directory_name' => [
'label' => '',
'type' => 'text',
'value' => '',
'placeholder' => __( 'Enter directory name', 'directorist' ),
'rules' => [
'required' => true,
],
],
'icon' => [
'label' => '',
'type' => 'icon',
Expand Down Expand Up @@ -2758,6 +2767,12 @@ protected static function prepare_data() {
'icon' => 'las la-home',
'container' => 'short-wide',
'sections' => [
'directory_name' => [
'title' => __( 'Directory name', 'directorist' ) . ' <span class="la la-pen"></span>',
'description' => __( 'Give your directory a unique name to identify it across listings, add listing, and search pages.', 'directorist' ),
'fields' => ['directory_name'],
],

'labels' => [
'title' => __( 'Directory icon', 'directorist' ),
'description' => __( 'Select a directory type icon to display in all listings, add listing, and search pages.', 'directorist' ),
Expand Down
5 changes: 5 additions & 0 deletions includes/modules/multi-directory-setup/class-multi-directory-manager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -845,6 +845,11 @@ public function update_fields_with_old_data( $listing_type_id = 0 ) {

self::$options['name']['value'] = $term_name;

// Sync directory_name field with the term name so it appears in the General tab.
if ( isset( self::$fields['directory_name'] ) ) {
self::$fields['directory_name']['value'] = $term_name;
}

$all_term_meta = get_term_meta( $term_id );
$test_migration = apply_filters( 'atbdp_test_migration', false );

Expand Down