Fix Google map marker pin icon rendering in listing maps#2718
Open
RabbiIslamRony wants to merge 1 commit intosovware:developmentfrom
Open
Fix Google map marker pin icon rendering in listing maps#2718RabbiIslamRony wants to merge 1 commit intosovware:developmentfrom
RabbiIslamRony wants to merge 1 commit intosovware:developmentfrom
Conversation
…d remove outdated SCSS override that forced , which conflicted with the JS marker setup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Description
This PR fixes the map marker icon rendering across Google Map views by ensuring a consistent icon source and removing conflicting legacy styles.
Before
https://prnt.sc/u6k5Gc2CeVYW
After
https://prnt.sc/WmL7gBkqYpiz
Changes included:
--directorist-iconinline to the correct Font Awesome marker SVG (map-marker-alt.svg).map-pin.svg, which conflicted with the JavaScript marker setup.Why
Previously, marker icons appeared inconsistent across different map contexts due to mixed icon sources (
map-pinvsmap-marker-alt) and a legacy SCSS override. This update standardizes icon rendering and eliminates style conflicts.Test Plan
Linked Issues
https://taiga-sovware-u10698.vm.elestio.app/project/directorist/issue/2605
Checklist