Use unsafe pointers for values that the kernel may update behind our backs #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bb010g
reviewed
Oct 18, 2020
Comment on lines
+33
to
+38
| /// # Safety | ||
| /// | ||
| /// Never call `std::mem::forget` on this value. | ||
| /// It can lead to a use-after-free bug. The fact | ||
| /// that `std::mem::forget` is not marked unsafe | ||
| /// is a bug in the Rust standard library. |
There was a problem hiding this comment.
Wasn't std::mem::forget actually being safe, against pre-1.0 thoughts/desires, the whole issue with the Leakpocalypse?
- Pre-Pitting Your Peaches With Rust, Alexis Beingessner, 27 Apr 2015
std::thread::JoinGuard(andscoped) are unsound because of reference cycles, std::thread::JoinGuard (and scoped) are unsound because of reference cycles rust-lang/rust#24292, Ariel Ben-Yehuda, 10 Apr 2015- RFC: Alter
mem::forgetto be safe, RFC: Alter mem::forget to be safe rust-lang/rfcs#1066, Alex Crichton, 16 Apr 2015
There was a problem hiding this comment.
Oh, nevermind, this documentation was covered & changed by #30 & #31.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.