Skip to content

feat: add ability to log to a file#885

Open
carlosm27 wants to merge 16 commits intosparckles:mainfrom
carlosm27:log_file
Open

feat: add ability to log to a file#885
carlosm27 wants to merge 16 commits intosparckles:mainfrom
carlosm27:log_file

Conversation

@carlosm27
Copy link
Contributor

Description

This PR fixes #841

This PR adds the ability to create a log file.
This is an example of how to do it:

Screenshot 2024-07-07 230957

Screenshot 2024-07-07 230937

@vercel
Copy link

vercel bot commented Jul 8, 2024

@carlosm27 is attempting to deploy a commit to the sparckles Team on Vercel.

A member of the Team first needs to authorize it.

@carlosm27
Copy link
Contributor Author

Should we add the ability to add more configurations, like timestamps, levels, etc?

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 8, 2024

CodSpeed Performance Report

Merging #885 will not alter performance

Comparing carlosm27:log_file (6a5c4d5) with main (51bf8a3)

Summary

✅ 146 untouched benchmarks

@carlosm27 carlosm27 changed the title feat : add ability to log to a file feat: add ability to log to a file Jul 8, 2024
@sansyrox
Copy link
Member

sansyrox commented Jul 9, 2024

Hey @carlosm27 👋

How would you use this new interface?

@carlosm27
Copy link
Contributor Author

Hey @carlosm27 👋

How would you use this new interface?

Hey @sansyrox. I would use it to create log files with timestamps, log level and with and add rotation policy.

What features are more appropiate for this interface?

@vercel
Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
robyn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 0:22am

@recurseml
Copy link

recurseml bot commented May 27, 2025

✨ No issues found! Your code is sparkling clean! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add an ability to log to a file

3 participants