Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add GIF Image Support to nbsphinx
Summary
This pull request adds support for rendering animated GIF images in Jupyter notebooks when using nbsphinx (see also #864 ). The implementation follows the same approach used in similar projects like WhipperSnapPy and the nbconvert PR for GIF support.
Note that we do not add a monkey patch for nbconvert here, so first the PR upstream needs to be merged before this will work.
Changes Made
1. Added
image/gifto Display Data Priority (HTML)src/nbsphinx/__init__.py'image/gif'to theDISPLAY_DATA_PRIORITY_HTMLtuple2. Added GIF File Extension Mapping
src/nbsphinx/__init__.py'image/gif': '.gif'to theTHUMBNAIL_MIME_TYPESdictionary.giffile extensions when saving GIF images as thumbnails or standalone files3. Updated RST Template for Image Directive
src/nbsphinx/__init__.py(RST_TEMPLATE)'image/gif'to the image directive handling condition in the Jinja2 templateimagedirective