Added bug collisions to bcrypt #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed char bug: $2y$ is using the correct code. The $2x$ (the old $2a$) extended the sign bit of a character on top of at most the 3 characters before it (4 byte boundary). Null char bug: nothing after the first null character is used. This breaks when using prehashed bcrypt with raw output.
spaze
force-pushed
the
master
branch
2 times, most recently
from
36493b3 to
6616e11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed char bug:$2y$ is using the correct code. The $2x$ (the old $2a$ ) extended the sign bit of a character on top of at most the 3 characters before it (4 byte boundary).
Null char bug: nothing after the first null character is used. This breaks when using prehashed bcrypt with raw output.