Conversation
When using SOURCE routing with many concurrent flows, the simulation crashed with 'Assertion sink != NULL failed' because newly created packets had stale/uninitialized hop_count values. Switches use hop_count to index into routing tables, so a too-large value causes lookup failures and packets routed to NULL sinks. Added set_hop_count(0) calls in 7 packet creation sites in uec.cpp, matching the sc25-spritz reference implementation: - UecSrc: sendNewPacket, sendRtxPacket, sendProbe, sendRTS - UecSink: pull, sack, nack Verified: All 22 functional tests pass, all 18 reachability tests pass (including sf_p4q5 one-to-all SOURCE with 199 flows, which previously crashed).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slimfly topology and routing.