Unify main entry points into single htsim_uec binary#12
Open
Unify main entry points into single htsim_uec binary#12
Conversation
Merge main_uec_df.cpp (Dragonfly) and main_uec_sf.cpp (SlimFly) into main_uec.cpp with a new -topology flag (fattree|dragonfly|slimfly). Key changes: - Add TopologyType enum and CLI flags: -topology, -basepath, -routing - Add Dragonfly/SlimFly code paths inside main_uec.cpp - Remove htsim_uec_df and htsim_uec_sf executables from CMakeLists.txt - Fix queue_type enum ODR violation in slimfly_topology.h (COMPOSITE was 1 in SF vs 3 in FT/DF headers) - Auto-detect packet size: 4150 for FatTree, 4160 for DF/SF - Fix Logged object lifetimes (move declarations before if/else block) - Update README documentation for unified binary usage All 22 functional tests and 18 reachability tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge main_uec_df.cpp (Dragonfly) and main_uec_sf.cpp (SlimFly) into main_uec.cpp with a new -topology flag (fattree|dragonfly|slimfly).
Key changes: