Open
Conversation
mcopik
requested changes
Mar 20, 2024
src/comm/S3.cpp
Outdated
| @@ -25,7 +25,7 @@ FMI::Comm::S3::S3(std::map<std::string, std::string> params, std::map<std::strin | |||
| upload_price = std::stod(model_params["upload_price"]); | |||
|
|
|||
| auto credentialsProvider = Aws::MakeShared<Aws::Auth::EnvironmentAWSCredentialsProvider>(TAG); | |||
Contributor
There was a problem hiding this comment.
Do we still need this variable?
Author
There was a problem hiding this comment.
No @mcopik. It should not be required because the latest S3 client has its own internal credentialsProvider
Contributor
|
@mujtaba1747 Thank you for the PR! I will test it with building layers for 3.9. I had just one comment for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #17
The lambda layer build fails due to an additional parameter in the S3Client constructor.
Newer version of the AWS S3 SDK does not require that extra parameter ie credentialsProvider