Conversation
Member
Author
|
@xsuchy - this is the PR fix for performance. It is still O(N!), but the inner loop is much faster so it completes in a reasonable amount of time. Part of me wants to redo the algorithm to be close to linear, but it's probably good enough with this PR. |
Member
Author
|
Note that the CI is failing due to #224 which is unrelated to this PR |
Only tokenize the license compares once. Improves performance approximately 2 orders of magnitude when processing the entire license list. Performance improvements are negligable for single licenses. Add a timeout to the future gets of cross reference URL details. During testing, this fetch stalled once - this change will create a warning but will prevent an application hang.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #226
Only tokenize the license compares once. Improves performance approximately 2 orders of magnitude when processing the entire license list. Performance improvements are negligable for single licenses.
Add a timeout to the future gets of cross reference URL details. During testing, this fetch stalled once - this change will create a warning but will prevent an application hang.