Skip to content

Fix JavaDoc errors #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
goneall merged 2 commits into from
Oct 26, 2025
Merged

Fix JavaDoc errors #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
038f805
Fix JavaDoc errors
goneall Oct 26, 2025
cdf1fa9
Add javadoc test to CI
goneall Oct 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
run: |
if [[ $SONAR_TOKEN != "" ]]; then
mvn clean org.jacoco:jacoco-maven-plugin:prepare-agent install sonar:sonar
mvn clean org.jacoco:jacoco-maven-plugin:prepare-agent javadoc:javadoc install sonar:sonar
else
mvn --batch-mode --update-snapshots verify
fi
17 changes: 2 additions & 15 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,15 +104,6 @@
</dependency>
</dependencies>
<profiles>
<profile>
<id>doclint-java8-disable</id>
<activation>
<jdk>[1.8,)</jdk>
</activation>
<properties>
<javadoc.opts>-Xdoclint:none</javadoc.opts>
</properties>
</profile>
<profile>
<id>release</id>
<build>
Expand Down Expand Up @@ -155,16 +146,12 @@
<version>3.12.0</version>
<configuration>
<quiet>true</quiet>
<source>8</source>
<javadocExecutable>${env.JAVA_HOME}/bin/javadoc</javadocExecutable>
<additionalparam>-Xdoclint:none</additionalparam>
<notimestamp>true</notimestamp>
<doclint>all,-missing</doclint>
</configuration>
<executions>
<execution>
<id>attach-javadocs</id>
<configuration>
<additionalparam>${javadoc.opts}</additionalparam>
</configuration>
<goals>
<goal>jar</goal>
</goals>
Expand Down
2 changes: 0 additions & 2 deletions src/org/spdx/licensexml/LicenseXmlDocument.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,6 @@ public class LicenseXmlDocument {
* @param v2ModelStore model store for SPDX Spec version 2 license and exceptions
* @param creationInfo Creation information to use for SPDX V3 licenses and exceptions
* @param copyManager copyManager to use for copying data between model stores
* @param currentListVersion version of the license list to include the license data
* @param releaseDate Date the license list is released
*/
public LicenseXmlDocument(File file, IModelStore v2ModelStore, IModelStore v3ModelStore,
IModelCopyManager copyManager, CreationInfo creationInfo) throws LicenseXmlException {
Expand Down