Server forwards ping event from the transports Connection.#353
Open
AdamMagaluk wants to merge 1 commit intospdy-http2:masterfrom
Open
Server forwards ping event from the transports Connection.#353AdamMagaluk wants to merge 1 commit intospdy-http2:masterfrom
ping event from the transports Connection.#353AdamMagaluk wants to merge 1 commit intospdy-http2:masterfrom
Conversation
Pass the `ping` event on the transports connection to the server's EventEmitter as the `_ping` event. The event passes the client requests socket to allow users to identify the the socket sending the ping request.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass the
pingevent on the transports connection to theserver's EventEmitter as the
_pingevent. The event passesthe client requests socket to allow users to identify the the
socket sending the ping request.
Note: I choose
_pingwith the underscore to identify thatthe typical use case is internal and unlikely to be used. Similar
to https://github.com/spdy-http2/node-spdy/blob/master/lib/spdy/agent.js#L71