This repository was archived by the owner on Sep 18, 2020. It is now read-only.
Creates ClassifierFactory for easier classifier creation #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eam/native-algorithms into feature/classifier_factory
…eam/native-algorithms into feature/classifier_factory # Conflicts: # appveyor.yml
Daroslaw
suggested changes
May 5, 2018
| /// <summary> | ||
| /// The factory for creating classifiers | ||
| /// </summary> | ||
| class ClassifierFactory |
Member
There was a problem hiding this comment.
Static class maybe? This is yet another class that does not store any state, so I think this will be a suitable approach.
| size_t minimalFillup, | ||
| size_t maximalFillup, | ||
| unsigned int iterationsLimit, | ||
| double tolerance) const |
Member
There was a problem hiding this comment.
That is a lot of parameters. Have you considered putting at least some of them into a struct like GaClassifierOptions or something similar?
| double tolerance) const | ||
| { | ||
| std::unique_ptr<IClassifier> classifier; | ||
| if (name == "svm") |
Member
There was a problem hiding this comment.
Sooo... in every other case an empty pointer to IClassifier is passed to the GaClassifier constructor?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added classifierFactory class for easier creation of classifiers