Skip to content

Conversation

@klpoland
Copy link
Collaborator

@klpoland klpoland commented Dec 5, 2025

No description provided.

@semanticdiff-com
Copy link

semanticdiff-com bot commented Dec 5, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  gateway/sds_gateway/static/js/actions/ShareActionManager.js  24% smaller
  gateway/sds_gateway/api_methods/models.py  18% smaller
  gateway/sds_gateway/static/js/share/ShareGroupManager.js  13% smaller
  gateway/sds_gateway/static/js/actions/DetailsActionManager.js  11% smaller
  gateway/sds_gateway/static/js/actions/DownloadActionManager.js  10% smaller
  gateway/sds_gateway/static/js/core/PageLifecycleManager.js  5% smaller
  gateway/sds_gateway/api_methods/migrations/0017_convert_dataset_authors_to_object_format.py  0% smaller
  gateway/sds_gateway/api_methods/migrations/0018_dataset_previous_version_alter_dataset_version.py  0% smaller
  gateway/sds_gateway/api_methods/migrations/max_migration.txt Unsupported file format
  gateway/sds_gateway/api_methods/serializers/dataset_serializers.py  0% smaller
  gateway/sds_gateway/static/js/actions/DownloadInstructionsManager.js  0% smaller
  gateway/sds_gateway/static/js/actions/VersioningActionManager.js  0% smaller
  gateway/sds_gateway/static/js/core/APIClient.js  0% smaller
  gateway/sds_gateway/static/js/core/DOMUtils.js  0% smaller
  gateway/sds_gateway/static/js/search/AssetSearchHandler.js  0% smaller
  gateway/sds_gateway/templates/users/components/dataset_list_table.html Unsupported file format
  gateway/sds_gateway/templates/users/dataset_list.html Unsupported file format
  gateway/sds_gateway/templates/users/files.html Unsupported file format
  gateway/sds_gateway/templates/users/group_captures.html  0% smaller
  gateway/sds_gateway/templates/users/partials/captures_page_table.html Unsupported file format
  gateway/sds_gateway/templates/users/partials/dataset_details_modal.html  0% smaller
  gateway/sds_gateway/templates/users/partials/dataset_version_control.html  0% smaller
  gateway/sds_gateway/templates/users/partials/review_create_dataset.html  0% smaller
  gateway/sds_gateway/templates/users/partials/sdk_download_modal.html  0% smaller
  gateway/sds_gateway/templates/users/partials/share_modal.html  0% smaller
  gateway/sds_gateway/templates/users/partials/web_download_modal.html  0% smaller
  gateway/sds_gateway/users/urls.py  0% smaller
  gateway/sds_gateway/users/views.py  0% smaller

@klpoland klpoland self-assigned this Dec 5, 2025
@klpoland klpoland added feature New feature or request gateway Gateway component javascript Pull requests that update non-trivial javascript code migrations Code changes that require data or schema migrations in the database. labels Dec 5, 2025
@klpoland
Copy link
Collaborator Author

klpoland commented Dec 9, 2025

In this PR:

  • Added versioning related model fields/update existing (version from CharField to IntegerField, add previous_version)
  • Created version creation modal, view, and UI manager
  • Refactored dataset list template to break out table rendering and reloading
  • Refactored page lifecycle and API client Javascript to handle refreshes and modal events more smoothly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request gateway Gateway component javascript Pull requests that update non-trivial javascript code migrations Code changes that require data or schema migrations in the database.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants