Skip to content

Conversation

@fwcd
Copy link
Contributor

@fwcd fwcd commented Jan 31, 2025

Currently subfixture windows are interpreted as global coordinates. This is a bit unintuitive, not just because they are named relative_window in the code, but also because it poses a few practical problems:

  • If the subfixture is positioned outside the main/parent fixture window, it will effectively not be used at all
  • The main fixture still affects the fixture's master (or anything not mapped to a subfixture), so there's a discrepancy that may result in odd lighting effects (color/position not being properly in sync)

This fixes the issue by interpreting the subfixture in the parent fixture's window/coordinate system:

Screenshot 2025-01-31 at 03 52 31

@fwcd fwcd force-pushed the fix-subfixture-relative-positioning branch from b0ae3f6 to dcf25e3 Compare January 31, 2025 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant