Refactor methods to correct behavior and add constructor#94
Open
nathaliafab wants to merge 1 commit intospgroup:developfrom
Open
Refactor methods to correct behavior and add constructor#94nathaliafab wants to merge 1 commit intospgroup:developfrom
nathaliafab wants to merge 1 commit intospgroup:developfrom
Conversation
barbosamaatheus
approved these changes
Jul 26, 2024
pauloborba
approved these changes
Jul 29, 2024
galilasmb
suggested changes
Jul 29, 2024
| public class DFPBaseSample { | ||
| private String text; | ||
|
|
||
| public DFPBaseSample(String text){ |
Collaborator
There was a problem hiding this comment.
Tem que executar os testes que usam esse arquivo como entrada. Principalmente porque os números das linhas foram alterados. Verificar se o teste continua passando e alterar as linhas.
Member
There was a problem hiding this comment.
@galilasmb podes fazer isso? Nathalia é da parte de testes, só está ajudando a gente de estática com esses ajustes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Este PR corrige os métodos normalizeWhiteSpace(), removeDuplicateWords() e cleanText(). Também adiciona um novo construtor à classe DFPBaseSample que aceita um parâmetro String text.