fix zonespanlist() function on distributed index#45
Open
MBoldyrev wants to merge 1 commit intosphinxsearch:masterfrom
Open
fix zonespanlist() function on distributed index#45MBoldyrev wants to merge 1 commit intosphinxsearch:masterfrom
MBoldyrev wants to merge 1 commit intosphinxsearch:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When searching on a distributed index containing multiple local indices, and the conditions for reusing sorter are met, the sorter is created and stored at line searchd.cpp:8257:
pLocalSorter = sphCreateQueue ( tQueueSettings );Then the local variable
tQueueSettingsleaves the 'if' block and disappears, together with itsm_uPackedFactorFlagsmember, whose value was not stored anywhere. This leads toCSphQuery::m_bZSlistbeing false regardlesszonespanlist()function presence in the query. As a result, garbage or crashes take place of the expected zone lists.