Open
Conversation
arndt-s
requested review from
amartinezfayo,
azdagron,
evan2645 and
rturner3
as code owners
Signed-off-by: arndt-s <17650715+arndt-s@users.noreply.github.com>
arndt-s
force-pushed
the
add_broker_api
branch
from
1912301 to
e435e01
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wasn't sure if
nextis the correct branch here. Adds SPIFFE Broker API to the spire-api-sdk.We could discuss putting it in go-spiffe too, but this API is not "consumer" facing so I don't think that would be the correct place and this here is more suitable.
SPIFFE PR: spiffe/spiffe#340
SPIRE PR: spiffe/spire#6594