Open
Conversation
Contributor
quiquepaz
commented
Sep 2, 2021
quiquepaz
commented
- Use logger instead of lager
- Migrate to rebar3
- Remove (broken) benchmarking support
- Fix dialyzer errors
- Update Makefile
motiejus
reviewed
Sep 2, 2021
Makefile
Outdated
|
|
||
| benchmark: erl_cache quick | ||
| ./erl_cache priv/bench.conf | ||
| dialyzer: .erl_cache.plt quick |
Contributor
There was a problem hiding this comment.
nit: I suggest removing quick target and use compile as a dependency to this target, since quick is quite confusing: I initially assumed quick is a "lightweight linter", like xref.
Contributor
Author
There was a problem hiding this comment.
@motiejus Sure, I don't really mind. quick is pretty much a leftover from rebar2 times, and I didn't want to remove it in case the make quick command was linked to any organizational process.
I'll gladly remove quick and use compile as a dialyzer dependency
- Use logger instead of lager - Migrate to rebar3 - Remove (broken) benchmarking support - Fix dialyzer errors - Update Makefile
motiejus
approved these changes
Sep 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.