Implement user blocking/unblocking flow#5
Conversation
armiol
left a comment
armiol
left a comment
There was a problem hiding this comment.
@Vladyslav-Kuksiuk please make sure to do the following things:
-
review this PR by yourself, and do that really-really thoroughly;
-
next time perform p.1 before submitting a PR.
| */ | ||
|
|
||
| /** | ||
| * Provides ChatSPN `User` commands and common commands interfaces. |
There was a problem hiding this comment.
We don't use back-ticks in Javadoc. We use {@code ...}.
And another thing is that I don't understand why you want to have a monospaced don't here.
Please review.
Same goes for the similar cases within this PR.
| string name = 2 [(required) = true]; | ||
| } | ||
|
|
||
| // A new user chats has been created. |
There was a problem hiding this comment.
This is hardly a piece of English.
Please do better.
|
|
||
| import "spine/core/user_id.proto"; | ||
|
|
||
| // A user profile view in the chatting system. |
There was a problem hiding this comment.
?
Please make sure to review your own work before submitting a PR.
Vladyslav-Kuksiuk
changed the title
UserChats creation flow
armiol
left a comment
armiol
left a comment
There was a problem hiding this comment.
@Vladyslav-Kuksiuk as discussed vocally, BlockUser does not to make much sense if sent to User aggregate, since it introduces some discrepancy (i.e. who blocks whom?). So please return to this PR later.
2 participants
This PR adds an implementation of the user blocking and unblocking flows.
User blocking flow model:
User unblocking flow model:
