Implement a component that draws a chart#44
Open
Artem-Semenov-dev wants to merge 7 commits intoshare-price-chartfrom
Open
Implement a component that draws a chart#44Artem-Semenov-dev wants to merge 7 commits intoshare-price-chartfrom
Artem-Semenov-dev wants to merge 7 commits intoshare-price-chartfrom
Conversation
…tainer` components.
…oDifferentRange` extension.
|
It's better to add labels to the axes, like in Google Finance.
|
Vladyslav-Kuksiuk
left a comment
Vladyslav-Kuksiuk
left a comment
There was a problem hiding this comment.
@Artem-Semenov-dev please see my comment.
Comment on lines
+100
to
+103
| * @param inMin The minimum value of the original range | ||
| * @param inMax The maximum value of the original range | ||
| * @param outMin The minimum value of the target range | ||
| * @param outMax The maximum value of the target range |
There was a problem hiding this comment.
Suggested change
| * @param inMin The minimum value of the original range | |
| * @param inMax The maximum value of the original range | |
| * @param outMin The minimum value of the target range | |
| * @param outMax The maximum value of the target range | |
| * @param inMin the minimum value of the original range | |
| * @param inMax the maximum value of the original range | |
| * @param outMin the minimum value of the target range | |
| * @param outMax the maximum value of the target range |
Also, it might be better to name the parameters as originalMin and targetMin.
Contributor
|
@Artem-Semenov-dev I am reassigning this PR to myself now. Going to finish it once I have an opportunity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the component purposed for the chart drawing.
An example of the chart view: