add docs for JS debugger in language docs#165
Conversation
content/v3/javascript-components.md
Outdated
|
|
||
| #### Setup | ||
|
|
||
| First, make sure that the extension is installed. Next verify that the templates are new enough to support debugging. This can be verified by looking `.vscode/setting.json` and verifying if something like the following is configured: |
There was a problem hiding this comment.
Maybe split this into "installing the extension" (once) and "setting up the project" (each project).
content/v3/javascript-components.md
Outdated
|
|
||
|  | ||
|
|
||
| **Note:** that the debugger currently does not follow sourcemaps for npm dependencies as some packages may not bundle the source code in the pacakge. |
There was a problem hiding this comment.
| **Note:** that the debugger currently does not follow sourcemaps for npm dependencies as some packages may not bundle the source code in the pacakge. | |
| **Note:** The debugger currently does not follow sourcemaps for NPM dependencies, as some packages do not bundle the source code in the package. |
content/v3/javascript-components.md
Outdated
|
|
||
| **Note:** that the debugger currently does not follow sourcemaps for npm dependencies as some packages may not bundle the source code in the pacakge. | ||
|
|
||
| ## Caveats |
There was a problem hiding this comment.
I am not sure but it feels like this has come adrift from the stuff about APIs and packages that it more naturally lives with perhaps?
There was a problem hiding this comment.
I do not follow this. Can you elaborate please?
There was a problem hiding this comment.
The "Caveats" section feels like it's talking primarily about APIs and packages. But it is now separated from the APIs and packages stuff by a long section about debugging - someone reading about the programming model will likely not check all the way to the bottom of the page to see it. So I am wondering if the debugging stuff should come after Caveats rather than before it?
There was a problem hiding this comment.
Ah got it. Moved the section above.
|
@karthik2804 Is this still on your radar? Sorry, I realise travel has thrown things out. |
|
@itowlson I will get to this today. |
701fe98 to
f9c2093
Compare
|
This should now be ready for review. |
itowlson
left a comment
There was a problem hiding this comment.
Mostly grammar/voice nitpicks but I do think we should reorganise the headings. The current structure is very very deep, but also very narrow (e.g. there is only one H3, so it's not grouping anything). Most of the rest is looking for consistency of voice. But the content looks fine.
content/v3/javascript-components.md
Outdated
|
|
||
| #### Setup | ||
|
|
||
| ##### Installing the Extension |
There was a problem hiding this comment.
Heading level 5?!?!?! Let's reassess the structure here. Maybe
## Debugging in VS Code
### Debugger Status
### Installing the Debugger
### Setting up a Project for Debugging
### Running a Project in the Debugger
(I don't feel that the "debugger is a work in progress" para needs to be a separate heading, this is just to retain the way you have it. For myself, I would make that note part of the front matter.)
content/v3/javascript-components.md
Outdated
|
|
||
|  | ||
|
|
||
| **Note:** The debugger currently does not follow sourcemaps for NPM dependencies, as some packages do not bundle the source code in the package. |
There was a problem hiding this comment.
What is the significance of this? Should we explain it in terms of what they can and cannot do, or will JS devs understand implicitly what this means for them?
There was a problem hiding this comment.
I have updated this to be more clear now. Let me know what you think.
c7e0a03 to
42e82e4
Compare
Signed-off-by: Karthik Ganeshram <kganeshr@akamai.com> small fixes based on suggestions Signed-off-by: Karthik Ganeshram <kganeshr@akamai.com>
Co-authored-by: itowlson <github@hestia.cc> Signed-off-by: Karthik Ganeshram <kganeshr@akamai.com>
Signed-off-by: Karthik Ganeshram <kganeshr@akamai.com>
42e82e4 to
97e624c
Compare
itowlson
left a comment
There was a problem hiding this comment.
Looks good - thank you!
Issues have been addressed but user has not been able to re-review
Adds docs for using the StarlingMonkey debugger with the JavaScript SDK for Spin.