Skip to content

Disable OpenTelemetry SDK during installation #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ThorstenHans wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Disable OpenTelemetry SDK during installation #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d5dc1c
fix: Disable OpenTelemetry SDK during installation
ThorstenHans Feb 18, 2026
b4ca60d
style: add blank line to separate re-enablement of OTEL SDKs
ThorstenHans Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .github/workflows/test-installer.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
name: Test Installer Script
on:
pull_request:
branches: [main]
paths:
- downloads/install.sh

jobs:
build:
runs-on: ubuntu-latest
steps:
- name: Checkout Code
uses: actions/checkout@v4
- name: Run installer
run: bash downloads/install.sh
7 changes: 7 additions & 0 deletions downloads/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,9 @@ current_dir=$(pwd)
# Define Spin directory name
spin_directory_name="/spin"

# Disable OpenTelemetry SDK
export OTEL_SDK_DISABLED=true

if [ -d "${current_dir}$spin_directory_name" ]; then
fancy_print 1 "Error: .$spin_directory_name already exists, please delete ${current_dir}$spin_directory_name and run the installer again."
exit 1
Expand Down Expand Up @@ -180,6 +183,10 @@ if [[ $STATIC = "false" ]]; then
else
fancy_print 0 "Step 5: Skipping plugin installation for OS with musl"
fi

# Re-Enable OpenTelemetry SDK
export OTEL_SDK_DISABLED=

# Direct to quicks-start doc
fancy_print 0 "You're good to go. Check here for the next steps: https://spinframework.dev/quickstart"
fancy_print 0 "Run './spin' to get started"
Loading