Allow sorting pages using indexmenu#503
Open
ZbigniewTomanek wants to merge 1 commit intosplitbrain:masterfrom
Open
Allow sorting pages using indexmenu#503ZbigniewTomanek wants to merge 1 commit intosplitbrain:masterfrom
ZbigniewTomanek wants to merge 1 commit intosplitbrain:masterfrom
Conversation
Owner
|
I'd prefer to have the dw2pdf plugin use an event that allows other plugins to extend/modify the collection of pages to be added. Then this could be added to the indexmenu plugin or implemented as a third plugin. In general the dw2pdf Plugin would need a bit of cleanup and refactoring to make that easily possible. The code here also has some problems in the details (like the use of a global) but it doesn't make sense to review this in detail, when at least I would be reluctant to merge this at all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modification solves the problem faced by users who want to print a pdf using their own page order.
A new sorting mode
indexmenuhas been added, which uses the {{indexmenu_n>}} tag used by the indexmenu plugin. In addition, theindexmenu_modeparameter has been added, taking values ofstrict- will raise an error if {{indexmenu_n>}} tag is not present in any of printed pagessoft- pages without {{indexmenu_n>}} tag will be sorted alphabeticallyExample print url: http://localhost/wiki:dokuwikit?do=export_pdfns&book_ns=wiki&mode=strict&book_title=Wiki&book_order=indexmenu&toclevels=1-3