Skip to content

XCMetrics client: Support for sending only the log of the current build.#74

Open
byohay wants to merge 1 commit intospotify:mainfrom
byohay:feature/upload-current-log-flag
Open

XCMetrics client: Support for sending only the log of the current build.#74
byohay wants to merge 1 commit intospotify:mainfrom
byohay:feature/upload-current-log-flag

Conversation

@byohay
Copy link
Contributor

@byohay byohay commented Jan 11, 2022

If the flag is set, Logs found in the logs directory other than the log
of the current build will be ignored. Previously Cached requests are
still uploaded.

If the flag is set, Logs found in the logs directory other than the log
of the current build will be ignored. Previously Cached requests are
still uploaded.
@byohay
Copy link
Contributor Author

byohay commented Jan 11, 2022

One thing I'm not so sure about that's somewhat related: Do cached logs that don't have cached requests ever get uploaded? From the code it looks like they don't

@byohay
Copy link
Contributor Author

byohay commented Jan 30, 2022

To answer my own question: Yes, they are retrieved in LogsFinderEffectHandler and are united with the new logs in CacheLogsEffectHandler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant