Add requests and limits in Resource

[lupasarin]

Hey, I just made a Pull Request!

Description

Motivation and Context

Have you tested this? If so, how?

Checklist for PR author(s)

• Changes are covered by unit test
• All tests pass
• Code coverage check passes
• Error handling is tested
• Errors are handled at the appropriate layer
• Errors that cannot be handled where they occur are propagated
• (optional) Changes are covered by system test
• Relevant documentation updated
• This PR has NO breaking change to public API
• This PR has breaking change to public API and it is documented

Checklist for PR reviewer(s)

• This PR has been incorporated in release note for the coming version
• Risky changes introduced by this PR have been all considered

[codecov]

Codecov Report

Merging #1005 (c7bd4f9) into master (261b2f6) will increase coverage by 0.10%.
The diff coverage is 87.50%.

@@             Coverage Diff              @@
##             master    #1005      +/-   ##
============================================
+ Coverage     92.39%   92.49%   +0.10%     
- Complexity     2131     2134       +3     
============================================
  Files           199      201       +2     
  Lines          8253     8315      +62     
  Branches        501      501              
============================================
+ Hits           7625     7691      +66     
+ Misses          514      508       -6     
- Partials        114      116       +2     

[RRap0so]

Good stuff! Should we do some additional checks? Like:

• Make sure resources requests < resource limit
• Enforce some kind of reasonable upper limit (without attrition folks might abuse this)
• Check syntax (gb, G, Mi or default to numeric values)

[RRap0so]

A couple of additional questions that I have:

• Do we always need to specify a resource.
• Are we handling backwards compatibility just fine? (Since we used the styx-scheduler part to trigger this)

Might need someone more versed in Styx. Good stuff!

[RRap0so]

This could be a Double and we default to G to reduce error proneness

[lupasarin]

Good stuff! Should we do some additional checks? Like:

• Make sure resources requests < resource limit
• Enforce some kind of reasonable upper limit (without attrition folks might abuse this)
• Check syntax (gb, G, Mi or default to numeric values)

Absolutely! upper limit and checks in general was in my TODO list but forgot in the end. Thanks for bringing it up!