Add Cloud Config sample#92
Open
therepanic wants to merge 1 commit intospring-projects-experimental:mainfrom
Open
Add Cloud Config sample#92therepanic wants to merge 1 commit intospring-projects-experimental:mainfrom
therepanic wants to merge 1 commit intospring-projects-experimental:mainfrom
Conversation
Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
therepanic
force-pushed
the
add-cloud-config-sample
branch
from
62520f4 to
65e2594
Compare
Author
|
You may also notice that I only did the sample with the native cloud config profile. And I basically believe that this sample will suffice. What do you think? Should I make tests for different profiles in this sample? |
Author
|
Hello @rwinch! Can you review this, please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is where I added
cloud-config-sample. Of interest, I usedprops.put(“spring.config.location”, “classpath:/application.yml”)to load application.yml for the spring context. If this can be done in a better way, I'd love to hear advice. To start the cloud config server, I was loading theConfigServerConfigurationbean.I also made the response check with .contains(“Hello!”), in order not to apply additional logic to extract the value from the json. Do you think such a check which is now enough?
Fix: #77