Add FileClasspathEntry validation#93
Open
therepanic wants to merge 1 commit intospring-projects-experimental:mainfrom
Open
Add FileClasspathEntry validation#93therepanic wants to merge 1 commit intospring-projects-experimental:mainfrom
therepanic wants to merge 1 commit intospring-projects-experimental:mainfrom
Conversation
therepanic
force-pushed
the
add-FileClasspathEntry-validation
branch
from
310cce7 to
147ca8d
Compare
rwinch
requested changes
Jun 18, 2025
Collaborator
rwinch
left a comment
rwinch
left a comment
There was a problem hiding this comment.
Thanks for the PR! Can you please add tests for this? I've also provided feedback inline.
| public FileClasspathEntry(String filePath) { | ||
| File file = new File(filePath); | ||
| if (!file.isDirectory() && !file.getName().toLowerCase().endsWith("jar")) { | ||
| throw new IllegalArgumentException("File must be a jar file or directory"); |
Collaborator
There was a problem hiding this comment.
Can you please include the file path in the error message?
Author
There was a problem hiding this comment.
Will it be enough for us?:
throw new IllegalArgumentException("File must be a jar file or directory " + filePath);
therepanic
force-pushed
the
add-FileClasspathEntry-validation
branch
2 times, most recently
from
c2e250e to
5853212
Compare
Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
therepanic
force-pushed
the
add-FileClasspathEntry-validation
branch
from
5853212 to
69b5789
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since it doesn't make sense to throw a non-directory or jar file into
FileClasspathEntry, I think it's worth adding a check to the constructor.Fix: #59