-
Notifications
You must be signed in to change notification settings - Fork 4
Add support for new matte colors #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hmm, spotted a potential issue. Currently, the read function (readNdef) uses the hex value to differentiate between the different possible colors in the list:
But at least one of these new matte colors apparently shares a hex value with an existing color, "Matte Ivory White" and "White" are both hex FFFFFF. So whichever one is found first in the list will be assumed to be the color that's being read. Is there another differentiating value on the tag that is writable that could narrow down the specific color further? Or could Matte Ivory White just be omitted from the list, and White can just stand-in for it? I suppose that wouldn't necessarily be ideal. |
Good observation. I hadn't thought of that. Here is where the matte is defined in Bambu Studio.
There is a concept of sub brand that isn't fully implemented yet in OpenSpool but is defined in the bambu mqtt protocol. A quick glance at the code seems to indicate that they aren't using sub brands but instead are using a separate top level filament type |
|
This might also overlap with #14, differentiating the brands. Looks like filament_id could also potentially be a good differentiator, like this one for the Matte Base:
It looks like that might be their base ID for their Matte filaments? If other manufacturers use this type of filament_id differentiation, and it's stored on the tag, it might be useful for differentiating specific types like matte, etc. but that would mean keeping a database of all the different possible types from the different manufacturers. Alternatively, if the top level filament info (i.e. "Bambu PLA Matte") is on all Bambu tags, then that info could be parsed when read. Like, possibly to recognize that the brand is Bambu, but regardless, to then know that the next word in the sequence is the material (PLA) and then the word after (if present) is a sub categorization, like Matte. If that's consistent with Bambu, it would at least work for Bambu spools. I see there's listings for Generic, PolyLite, OverTure, etc. in that BambuStudio repo. So possibly the same could be done for other brands, as well? |
Addresses #32
I think this covers all of the new Bambu Lab matte colors, and their hex codes.
I just assumed that "matte_" followed by the color name would be appropriate for the color value, but feel free to change that if that was a bad assumption. I admittedly don't know what those values are used for, or if they need to follow a specific naming convention.
Got the hex values from:
https://ca.store.bambulab.com/products/pla-matte