Skip to content

🛡️ Sentinel: [HIGH] Fix DoS vulnerability in version comparison #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
google-labs-jules wants to merge 1 commit into from
Closed

🛡️ Sentinel: [HIGH] Fix DoS vulnerability in version comparison #805

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ export const EOL_DATES: Record<string, string> = {
"24": "2028-04-30",
};

/**
* Maximum length for a version string to prevent DoS.
*/
const MAX_VERSION_LENGTH = 256;

/**
* Check if a major version is EOL.
*/
Expand Down Expand Up @@ -52,6 +57,11 @@ export const getVersion = (): NodeVersion => {
* Compare the current node version with a target version string.
*/
const compareTo = (target: string): number => {
// DoS Prevention: Limit version string length
if (target.length > MAX_VERSION_LENGTH) {
return NaN;
}

if (target !== target.trim() || target.length === 0) {
return NaN;
}
Expand Down