🛡️ Sentinel: Improve EOL detection for odd and legacy versions#807
🛡️ Sentinel: Improve EOL detection for odd and legacy versions#807google-labs-jules[bot] wants to merge 1 commit intomainfrom
Conversation
- Added EOL dates for odd versions (17, 19, 21, 23) and older LTS versions (12, 14, 16) to `EOL_DATES`. - Updated `checkEOL` to fallback to checking if major < 12 for very old versions. - Added comprehensive tests for EOL scenarios including odd versions.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🦋 Changeset detectedLatest commit: 6dbcaf1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #807 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 46 50 +4
Branches 16 17 +1
=========================================
+ Hits 46 50 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Superseded by #826 - closing duplicate bot-generated PR |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
1 participant
🛡️ Sentinel: [Security Enhancement] Improve EOL detection
Vulnerability:
The library previously only checked EOL status against a hardcoded list of recent LTS versions (18, 20, 22, 24). This meant that running on:
isEOL: false.isEOL: false(if not in the map).This could mislead users or tools relying on this library into thinking they are running on a supported, secure Node.js version when they are not.
Fix:
EOL_DATESto include versions 12, 14, 16, 17, 19, 21, 23.checkEOLlogic to explicitly mark any major version < 12 as EOL.Verification:
bun run testpasses.isEOL: true.PR created automatically by Jules for task 10994980416293653299 started by @srod
Summary by cubic
Improves Node EOL detection to correctly flag odd majors and legacy versions as unsupported, ensuring accurate security warnings. Adds missing EOL dates and a safe fallback for very old versions.
Written for commit 6dbcaf1. Summary will update on new commits.