🛡️ Sentinel: Fix EOL detection for older and odd Node.js versions#812
🛡️ Sentinel: Fix EOL detection for older and odd Node.js versions#812google-labs-jules[bot] wants to merge 1 commit intomainfrom
Conversation
- Add missing EOL dates for Node.js versions 12, 14, 16 - Add EOL dates for odd versions 19, 21, 23, 25 - Update checkEOL to automatically consider versions < 12 as EOL - Ensure accurate security reporting for older environments
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🦋 Changeset detectedLatest commit: 4dd5bd0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #812 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 46 49 +3
Branches 16 17 +1
=========================================
+ Hits 46 49 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Superseded by #826 - closing duplicate bot-generated PR |
This PR updates the End-of-Life (EOL) detection logic in
src/index.tsto accurately identify older and odd-numbered Node.js versions as EOL.Previously,
checkEOLonly returned true if the major version existed in theEOL_DATESmap and the current date was past the EOL date. The map only contained recent even-numbered LTS versions (18, 20, 22, 24). This meant that:The fix:
major < 12to instantly flag ancient versions as EOL.EOL_DATESto include dates for Node 12, 14, 16, 18, 20, 22, 24, and odd versions 19, 21, 23, 25.This ensures that security tools and consumers relying on
isEOLget accurate information about the security status of the Node.js runtime.PR created automatically by Jules for task 16069661776977529000 started by @srod
Summary by cubic
Fix EOL detection so older and odd-numbered Node.js versions are correctly flagged as End-of-Life. This removes false “supported” results and ensures accurate security status for isEOL consumers.
Written for commit 4dd5bd0. Summary will update on new commits.