Skip to content

New Makefile build system (squashed)#140

Open
hasufell wants to merge 9 commits intostable-ghc-9.14from
stable/hasufell/local-store
Open

New Makefile build system (squashed)#140
hasufell wants to merge 9 commits intostable-ghc-9.14from
stable/hasufell/local-store

Conversation

@hasufell
Copy link
Member

@hasufell hasufell commented Feb 2, 2026

No description provided.

@hasufell hasufell force-pushed the stable/hasufell/local-store branch 2 times, most recently from 8124f76 to 75c4ec7 Compare February 16, 2026 09:58
@hasufell hasufell force-pushed the stable/hasufell/local-store branch from 75c4ec7 to 5777c15 Compare February 16, 2026 10:21
@hasufell hasufell requested a review from angerman as a code owner February 16, 2026 13:18
@angerman
Copy link

Can we have a good description for this PR and what it changes? It seems to change multiple things, not just the Makefile.

There is at least

  • some wasm change in there?
  • some version logic change and other GHC-boot changes that seem(?) not related to the Makefile?
  • buildsystem and Makefile changes (as well as a cabal bump, which I believe is related?)

The last one is what I expected. The other changes seem confusing to me form the PR title?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any commentary on this notes file? E.g. can we get a small introduction at the top? I'm all for documentation, this is great! I'm just lost at what I'm looking at.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still super confused as to why this change is part of this PR.

@angerman angerman mentioned this pull request Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we drop the __PIC__ ifdefs here?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be the revert of ghc@98a32ec.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change needed? Where do we use this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants