feat: add route_dependencies attribute to transaction extensions#885
Draft
feat: add route_dependencies attribute to transaction extensions#885
Conversation
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'STAC FastAPI Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.30.
| Benchmark suite | Current: a3ff0fd | Previous: 2e2b0f9 | Ratio |
|---|---|---|---|
Items With Model validation (100) |
116.6396950108403 iter/sec (stddev: 0.006995198306056394) |
157.22439379368063 iter/sec (stddev: 0.00008602307183466387) |
1.35 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #884
Related Issue(s):
Description:
This adds a new argument to the
TransactionExtensionandBulkTransactionExtensionthat makes it simple to add a dependency to all routes affected by the transactions extensions. It is possible that we would want to build off of the existingadd_route_dependenciespathway instead of doing this within the extension, see #884 for some discussion around that point.PR Checklist:
pre-commithooks pass locallymake test)make docs)