Skip to content

feat(dom): Add toHaveClass , toHaveAllClasses, and toHaveAnyClass assertions#134

Merged
JoseLion merged 6 commits intomainfrom
feat/dom-have-class
May 5, 2025
Merged

feat(dom): Add toHaveClass , toHaveAllClasses, and toHaveAnyClass assertions#134
JoseLion merged 6 commits intomainfrom
feat/dom-have-class

Conversation

@fonsiher
Copy link
Contributor

@fonsiher fonsiher commented Oct 3, 2024

Added the toHaveClass matcher.

@fonsiher fonsiher marked this pull request as ready for review October 4, 2024 20:17
@fonsiher fonsiher force-pushed the feat/dom-have-class branch from 6827334 to 18f9d98 Compare October 4, 2024 20:18
ChristianSama
ChristianSama approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@ChristianSama ChristianSama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @fonsiher. Thank you!

JoseLion
JoseLion reviewed Oct 24, 2024
View reviewed changes
Copy link
Contributor

@JoseLion JoseLion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, but I think we can improve things if we create 3 assertions instead of one 🙂

@fonsiher fonsiher force-pushed the feat/dom-have-class branch 2 times, most recently from 6e6062d to a831c90 Compare April 3, 2025 17:34
@fonsiher fonsiher requested review from JoseLion, KevinJ1998 and kdquistanchala and removed request for matycarolina April 3, 2025 17:35
suany0805
suany0805 approved these changes Apr 23, 2025
View reviewed changes
Copy link
Contributor

@suany0805 suany0805 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename the PR to contain all the toHaveClass , toHaveAllClasses, toHaveAnyClass 👀 please?

JoseLion
JoseLion reviewed Apr 24, 2025
View reviewed changes
Copy link
Contributor

@JoseLion JoseLion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I left some comments and suggestions. Let me know if you have any questions 🙂

@fonsiher fonsiher changed the title feat(dom): DOM - toHaveClass feat(dom): DOM - ttoHaveClass , toHaveAllClasses and toHaveAnyClass Apr 24, 2025
@fonsiher fonsiher force-pushed the feat/dom-have-class branch from a831c90 to 8805f6f Compare April 28, 2025 22:04
@fonsiher fonsiher changed the title feat(dom): DOM - ttoHaveClass , toHaveAllClasses and toHaveAnyClass feat(dom): DOM - toHaveClass , toHaveAllClasses and toHaveAnyClass Apr 28, 2025
@fonsiher fonsiher force-pushed the feat/dom-have-class branch from 0d3c0c6 to e512c76 Compare April 28, 2025 22:17
@fonsiher
Copy link
Contributor Author

fonsiher commented Apr 28, 2025

Thanks for your review @JoseLion , you're right, I've added the prop to the testing function and now are using getByText for render the element for Testing.
You check this in my last commit. Feel free to take a look at it, and let me know if you have more comments or suggestions. TY.

JoseLion
JoseLion approved these changes May 5, 2025
View reviewed changes
Copy link
Contributor

@JoseLion JoseLion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Nice work @fonsiher 🎉

@JoseLion JoseLion changed the title feat(dom): DOM - toHaveClass , toHaveAllClasses and toHaveAnyClass feat(dom): Add toHaveClass , toHaveAllClasses, and toHaveAnyClass assertions May 5, 2025
@JoseLion JoseLion merged commit bd8b2a7 into main May 5, 2025
4 checks passed
@JoseLion JoseLion deleted the feat/dom-have-class branch May 5, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristianSama ChristianSama ChristianSama approved these changes

@suany0805 suany0805 suany0805 approved these changes

@kdquistanchala kdquistanchala Awaiting requested review from kdquistanchala

@KevinJ1998 KevinJ1998 Awaiting requested review from KevinJ1998

+1 more reviewer

@JoseLion JoseLion JoseLion approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@fonsiher fonsiher

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fonsiher @JoseLion @ChristianSama @suany0805