chore: Replace haskell.nix with stacklock2nix#251
Merged
Conversation
Co-authored-by: Fabricio Mera <fmera@stackbuilders.com> Co-authored-by: David Becerra <dbecerra@stackbuilders.com>
sestrella
changed the title
This reverts commit 179ebdd.
sestrella
changed the title
haskell.nix with stacklock2nix
fm7-1
reviewed
Mar 27, 2025
fm7-1
reviewed
Mar 27, 2025
Comment on lines
+75
to
+76
| - name: Setup Cachix | ||
| uses: cachix/cachix-action@v16 |
Contributor
DavidMazarro
left a comment
DavidMazarro
left a comment
There was a problem hiding this comment.
Great work Sebas! So much simpler :) I left a couple of comments
sestrella
commented
Mar 28, 2025
| { | ||
| default = | ||
| pkgs.lib.warnIf (builtins.any (x: x == system) unstestedSystems) | ||
| "'${system}' is not tested as part of the CI workflow; please report any issues you encounter while dealing with it." |
Member
Author
There was a problem hiding this comment.
@DavidMazarro I added a warning message for aarch64-linux and x86_64-darwin because we are not currently building against them on the CI.
sestrella
commented
Mar 28, 2025
| , System.Hapistrano.Maintenance | ||
| build-depends: aeson >= 2.0 && < 3.0 | ||
| , ansi-terminal >= 0.9 && < 0.12 | ||
| , ansi-terminal >= 0.9 && < 2.0 |
Member
Author
There was a problem hiding this comment.
I am keeping the original lower bound for all the dependencies where I bumped the upper bound to avoid introducing some breaking changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to simplify the current Nix setup for building the project by replacing
haskell.nixwithstacklock2nix, which has a simple interface and generates Nix derivations using the existingstack.yaml.lock. Additionally, it configures 'devenv' to provide Nix contributors with a development environment shell that includes all of the tooling needed to build and test the project.Q&A
@fm7-1, @CristhianMotoche, @DavidMazarro I'm just trying to provide some background for the thought process behind some of the changes included in this PR; I'd be happy to discuss this with you if you have any concerns.
Why did the stack resolver get upgraded?
GHC 8.10.4 does not have great support for Apple Silicon, but given that Hapistrano is intended to be used as a tool rather than a library, upgrading the compiler to a more recent version should not be a major issue.