Skip to content

Spearbit audit #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hazim-j merged 42 commits into from
Aug 18, 2025
Merged

Spearbit audit #23

hazim-j merged 42 commits into from
Aug 18, 2025

Conversation

@hazim-j
Copy link
Member

@hazim-j hazim-j commented Aug 1, 2025

No description provided.

hazim-j added 30 commits August 1, 2025 12:20
@hazim-j
Findings 7: Cache array length in for loops (#22)
13f49e3
@hazim-j
Findings 16: use verifyCalldata in registerNode (#24)
a8f698b
@hazim-j
Findings 1: Consistent custom errors everywhere (#25)
871f218
@hazim-j
Findings 2: Use max uint32 for permanent entryPoint stake (#26)
50169ad
@hazim-j
Findings 3: rename _refHash to refHash (#27)
65d8919
@hazim-j
Findings 5: document cache mechanism in spec.md (#28)
41424bc
@hazim-j
Findings 6: clarify conversion of node hash bytes conversion (#29)
f2dac32
@hazim-j
Findings 10: document contract dependencies for P256 verifiers (#30)
2a1a3aa
@hazim-j
Findings 15: use native slicing in registerNode (#31)
70fa4d3
@hazim-j
Findings 17: add comment to address intentional missing short-circuit (…
eb82bde 
…#32)
@hazim-j
Findings 20: change input to nodeHash in getRegisteredNode() (#33)
36bb876
@hazim-j
Findings 21: define a constant for node verifier length (#34)
f1aee89
@hazim-j
Findings 23: remove unnecessary conditional in _unpackNode() (#35)
4bfb5cc
@hazim-j
Findings 24: rename _validateNode to _fetchOrValidateNode (#36)
abba4d9
@hazim-j
Findings 25: use named params for nested mappings (#37)
34deb80
@hazim-j
Findings 27: inherit TokenCallbackHandler to store ERC721 and ERC1155…
338e904 
… tokens (#38)
@hazim-j
Findings 32: update spec Actions and root hash storage sections (#39)
0772a05
@hazim-j
Findings 33: document address collision edge case with same refHash (#40
229b436 
)
@hazim-j
Findings 35: document expected verifier data and config inputs (#41)
29d0e88
@hazim-j
Findings 14: enforce minimum multi-sig threshold of 1 (#42)
3db5c9b
@hazim-j
Findings 28: add dev note on expected invalid sig revert (#43)
c146ac9
@hazim-j
fix: typo in dev comment
9d9071a
@hazim-j
Findings 29: revert if more than max uint8 owners (#44)
83a7a8c
@hazim-j
Findings 30: revert if more than max uint8 signatures (#45)
a93369a
@hazim-j
Findings 19: enforce unique owner set (#46)
be19fb5
@hazim-j
Findings 19: enforce number of owners to be >= threshold (#47)
6d6fa03
@hazim-j
Findings 37: defensive rehashing scheme with ERC-7739 (#48)
e97a279
@hazim-j
Findings 40: switch to ERC-1167 minimal proxies (#49)
aef485e
@hazim-j
Findings 38: add useChainId flag (#50)
6f90630
@hazim-j
Findings 8: document handleUpdates revert scenarios (#51)
a8cd8c8
@hazim-j hazim-j changed the title Spearbit audit fixes Spearbit audit Aug 14, 2025
@hazim-j hazim-j merged commit 3ed7afe into main Aug 18, 2025
2 checks passed
@hazim-j hazim-j deleted the spearbit-audit branch August 18, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hazim-j