iOS: Add Route Preview to Demo App and CarPlay#643
Draft
bolsinga wants to merge 11 commits intostadiamaps:mainfrom
Draft
iOS: Add Route Preview to Demo App and CarPlay#643bolsinga wants to merge 11 commits intostadiamaps:mainfrom
bolsinga wants to merge 11 commits intostadiamaps:mainfrom
Conversation
- It's Green, because why not? - In `DemoModel`, the `MapViewCamera` is overridden if there is a `selectedRoute`. The `MapViewCamera` will then be the bounds of the `Route`. -- This works in the iOS application via `DynamicallyOrientingNavigationView`, but does **not** work in `CarPlayNavigationView`. It's not clear to me why yet.
Collaborator
Author
|
Hmm. I noticed CarPlay doing the "right thing" if I run navigation by tapping in the iOS app. Let me look at this more before reviewing. |
Collaborator
Author
|
Also misbehaves in iOS when zooming the map while the route preview is showing.... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DemoModel, theMapViewCamerais overridden if there is aselectedRoute. TheMapViewCamerawill then be the bounds of theRoute.-- This works in the iOS application via
DynamicallyOrientingNavigationView, but does not work inCarPlayNavigationView. It's not clear to me why yet.