fix: nil value handling in tplvalues.render helper #486
+54
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
image.digestis undefined in values, templates renderimage:tag@nullinstead ofimage:tag. Theapplication.tplvalues.renderhelper convertsnilto string"null"viatoYaml, which passes{{- with }}checks since"null"is non-empty.Changes
_helpers.tpl: Updatedapplication.tplvalues.renderto check for nil/invalid values before processing and return empty string instead of converting to"null"Technical Details
The helper now short-circuits on nil/invalid values:
{{- define "application.tplvalues.render" -}} {{- $value := .value -}} {{- if or (not $value) (kindIs "invalid" $value) -}} {{- "" -}} {{- else if typeIs "string" $value -}} {{- tpl $value .context -}} {{- else -}} {{- tpl ($value | toYaml) .context -}} {{- end -}} {{- end -}}This fix benefits all uses of
tplvalues.renderthroughout the chart, not just image handling. The{{- with }}checks now behave as expected for undefined values.Before:
nginx:latest@nullAfter:
nginx:latestOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.