Update library #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces new SwiftUI extension utilities and improvements for view modifiers, bindings, and color utilities in the SwiftUIHelpers library.
- Adds view modifiers for hit testing and hiding views.
- Provides additional extensions for fonts, colors, edge insets, content size categories, and bindings.
- Updates Package.swift and CI workflows to support newer Swift and platform versions.
Reviewed Changes
Copilot reviewed 70 out of 70 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Sources/SwiftUIExtensions/View+HitTestAreaPadding.swift | Adds padding modifications for hit test areas. |
| Sources/SwiftUIExtensions/View+Hidden.swift | Introduces a hidden view modifier with an option to remove the view. |
| Sources/SwiftUIExtensions/View+EmbedInNavigation.swift | Provides a function to embed Views in a NavigationStack. |
| Sources/SwiftUIExtensions/UIColor+ColorScheme.swift | Implements dynamic color support for light/dark mode. |
| Sources/SwiftUIExtensions/Image+Resizable.swift | Adds resizable image extension with content mode handling. |
| Sources/SwiftUIExtensions/Font/*.swift | Maps Font designs, weights, and text styles to UIKit counterparts. |
| Sources/SwiftUIExtensions/Environment+IsPreview.swift | Detects SwiftUI previews via environment values. |
| Sources/SwiftUIExtensions/EdgeInsets+Init.swift | Adds a convenient initializer for symmetrical insets. |
| Sources/SwiftUIExtensions/DynamicTypeSize+ContentSizeCategory.swift | Provides interoperability between DynamicTypeSize and ContentSizeCategory. |
| Sources/SwiftUIExtensions/Color+Random.swift | Adds a random color generator. |
| Sources/SwiftUIExtensions/Color+AccessibleFontColor.swift | Adjusts font colors for accessibility contrast. |
| Sources/SwiftUIExtensions/Binding.swift & Binding+*.swift | Extend binding functionalities with several utility methods. |
| Package.swift | Upgrades Swift tools version and updates platforms/dependencies. |
| .github/workflows/tests.yml | Configures the CI workflow for building and testing the project. |
|
|
||
| public func body(content: Content) -> some View { | ||
| if isHidden { | ||
| if !remove { |
There was a problem hiding this comment.
When 'isHidden' is true and 'remove' is also true, no view is returned from the body, leading to a missing view branch. Consider returning an EmptyView() in this case to maintain a consistent return type.
Suggested change
| if !remove { | |
| if remove { | |
| EmptyView() | |
| } else { |
There was a problem hiding this comment.
Pull Request Overview
This PR updates and extends the SwiftUIHelpers library by adding several new view modifiers, extensions for UIKit interoperability, and binding utilities while also updating package configuration and CI.
- Introduces new view modifiers such as hit test area padding, hidden view handling, and navigation embedding.
- Adds extensions for UIColor, Image, Font, Environment, EdgeInsets, DynamicTypeSize, and Color to improve UI customization and interoperability.
- Implements new Binding utilities and updates Package.swift and GitHub Actions CI workflow for builds and tests.
Reviewed Changes
Copilot reviewed 86 out of 86 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Sources/SwiftUIExtensions/View+HitTestAreaPadding.swift | Adds hit test area padding modifier with a negative padding hack for extended touch areas. |
| Sources/SwiftUIExtensions/View+Hidden.swift | Implements a view extension to hide or completely remove a view using a custom modifier. |
| Sources/SwiftUIExtensions/View+EmbedInNavigation.swift | Provides a helper method to embed views in a NavigationStack with configurable title display modes. |
| Sources/SwiftUIExtensions/UIColor+ColorScheme.swift | Introduces dynamic UIColor initializer to support light/dark mode. |
| Sources/SwiftUIExtensions/Image+Resizable.swift | Adds a convenient resizable image helper that adapts aspect ratio based on content mode. |
| Sources/SwiftUIExtensions/Font/UIFontDescriptor.SystemDesign+Font.Design.swift | Maps Font.Design to corresponding UIFontDescriptor.SystemDesign values. |
| Sources/SwiftUIExtensions/Font/UIFont.Weight+Font.Weight.swift | Maps Font.Weight to UIFont.Weight with a fallback using rawValue mapping for custom cases. |
| Sources/SwiftUIExtensions/Font/UIFont.TextStyle+Font.TextStyle.swift | Maps Font.TextStyle to UIKit text styles. |
| Sources/SwiftUIExtensions/Environment+IsPreview.swift | Provides an Environment value and helper view for detecting SwiftUI previews. |
| Sources/SwiftUIExtensions/EdgeInsets+Init.swift | Offers an initializer for EdgeInsets to construct symmetrical insets easily. |
| Sources/SwiftUIExtensions/DynamicTypeSize+ContentSizeCategory.swift | Converts DynamicTypeSize to a corresponding ContentSizeCategory with a default fallback. |
| Sources/SwiftUIExtensions/Color+Random.swift | Adds a static property to generate random colors. |
| Sources/SwiftUIExtensions/Color+AccessibleFontColor.swift | Implements a method to determine a contrasting font color based on the background color. |
| Sources/SwiftUIExtensions/Binding.swift | Enhances Binding to select an identifiable element from a collection. |
| Sources/SwiftUIExtensions/Binding+Equals.swift | Introduces a boolean binding initializer that reflects equality to a given value. |
| Sources/SwiftUIExtensions/Binding+Boolean.swift | Adds a computed binding property to represent the presence or absence of a value as a boolean. |
| Sources/SwiftUIExtensions/Binding+??.swift | Overloads the nil coalescing operator for Bindings to provide a non-optional view. |
| Package.swift | Updates swift-tools version, platform requirements, and dependencies for enhanced compatibility. |
| .github/workflows/tests.yml | Adds a CI workflow to build and test the Swift project using the latest Xcode version. |
Comments suppressed due to low confidence (1)
Sources/SwiftUIExtensions/Binding+??.swift:2
- [nitpick] The filename 'Binding+??.swift' is ambiguous and may lead to confusion. Renaming the file to something like 'Binding+NilCoalescing.swift' would improve clarity.
// Binding+??.swift
|
|
||
| public func body(content: Content) -> some View { | ||
| if isHidden { | ||
| if !remove { |
There was a problem hiding this comment.
When isHidden is true and remove is true, no view is returned, which breaks the view hierarchy. Consider returning an EmptyView() or a similar placeholder in this branch to ensure a valid view is always provided.
Suggested change
| if !remove { | |
| if remove { | |
| EmptyView() | |
| } else { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.