Conversation
|
Não vou poder revisar agora, mas batendo o olho tem muitos arquivos que eu creio que não estão sendo utilizados. Amanhã dou uma olhada com calma. Cc: @gabrielcardoso21 |
DiegoParadeda
force-pushed
the
feature/sisdeb
branch
from
cb46679 to
3e9776f
Compare
|
@DiegoParadeda o código parece funcional. Entretanto os arquivos da pasta file e result estão muito parecidos com as mesmas pastas do módulo sipag Seria interessante adaptar um pouco a estrutura da lib para que as duas funcionalidades convivam bem sem muito código duplicado. Mas tb gostaria da opilião dos autores..... As vezes não vale a pena mexer em time que esta ganhando mesmo duplicando um pouco de código. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds debit file generator and parser